Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hardcode path to wp-content #22

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Don't hardcode path to wp-content #22

merged 1 commit into from
Dec 3, 2019

Conversation

joshfeck
Copy link
Contributor

@joshfeck joshfeck commented Dec 2, 2019

See "Calling file locations poorly" in issue #15

Changes affect CSV import and CSV import has been tested on this branch.

@joshfeck joshfeck added this to the 3.1.37.18 milestone Dec 2, 2019
@joshfeck joshfeck requested a review from sethshoultes December 2, 2019 19:22
sethshoultes
sethshoultes approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@sethshoultes sethshoultes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I verified the import still works.

@joshfeck joshfeck merged commit 7b17009 into master Dec 3, 2019
@joshfeck joshfeck deleted the BUG/wp-content-dir branch December 3, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethshoultes sethshoultes sethshoultes approved these changes

Assignees

@sethshoultes sethshoultes

@joshfeck joshfeck

Labels
None yet
Projects
None yet
Milestone
3.1.37.18
Development

Successfully merging this pull request may close these issues.
2 participants
@joshfeck @sethshoultes