Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow of variants in productView/Variants.jsx #339

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

kaysond
Copy link
Contributor

@kaysond kaysond commented Sep 27, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

If a product has too many variants, it overflows the page

image

Issue Number: N/A

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Use flex-wrap to wrap variants and gap to keep consistent gap between rows and columns

@kaysond
Copy link
Contributor Author

kaysond commented Oct 14, 2023

@treoden - can you please merge this? :)

@treoden treoden merged commit 54894ae into evershopcommerce:main Oct 14, 2023
2 checks passed
@kaysond kaysond deleted the patch-1 branch October 14, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants