Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests dont run #16

Open
osdiab opened this issue Dec 2, 2020 · 0 comments
Open

Tests dont run #16

osdiab opened this issue Dec 2, 2020 · 0 comments
Assignees
@osdiab
Labels
bug Something isn't working p1 tooling

Comments

@osdiab
Copy link
Contributor

osdiab commented Dec 2, 2020

We should get them to run. Some issues:

  • for src/components/EveryMonth/EveryMonth.test.js: Jest encountered an unexpected token - looks like code is not getting downcompiled to node-compatible environment properly
  • for docs/every-month/test.js: ReferenceError: window is not defined - looks like code isn't formatted to work serverside either
  • Library still uses @testing-library/react despite the app using Preact

Suggestion: along with just making it work I'd also like to switch over to ava as well since its generally a simpler to configure and use tool that does what we need to do.
@osdiab osdiab added the bug Something isn't working label Dec 2, 2020
This was referenced Feb 5, 2021
Merged
Closed
@osdiab osdiab added the p1 label Feb 10, 2021
@osdiab osdiab self-assigned this Feb 10, 2021
@osdiab osdiab added the tooling label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osdiab osdiab

Labels
bug Something isn't working p1 tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osdiab