-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript, xo for linting, ava for testing #74
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/p22/every-month/i2832fdtj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! So good to get these things set up :)
…ab/migrate-typescript
a lot of follow ups from this now that i've thoroughly spelunked the code, to improve its stability! |
tests still failing, ill figure it out in a later PR |
f5f1946
to
f7b1fc4
Compare
seems it thinks the docs needs updating since the preact config now results in my local directories being included in the sourcemap paths. that's odd |
im just gonna land this for now since it's a net benefit, and deal with the script issues after |
Current challenge: HTMLWebpackPlugin seems to not work, maybe because I upgraded preact-cli. it looks like there are two HTML webpack plugin instances so how we override appears to be broken. Not totally sure how to debug (cc @jake-nz ), related #75 , will try to revert the preact-cli bump
once that works then can do more thorough testing
closes #11
closes #17
part of #16