Join multiple email addressess with semi-colons

Some members have multiple email addresses. Previously MemberPage was capturing them joined as one contiguous string. With this commit, multiple email addresses are now delimited with semi-colons.
everypolitician-scrapers · Jul 14, 2017 · 6b307bf · 6b307bf
1 parent e66515f
commit 6b307bf
Show file tree

Hide file tree

Showing 3 changed files with 145 additions and 1 deletion.
diff --git a/lib/member_page.rb b/lib/member_page.rb
@@ -38,7 +38,7 @@ class MemberPage < Scraped::HTML
   end
 
   field :email do
-    bio.xpath('//table/tr/td/a[contains(@href, "mailto")]/text()').to_s.tidy
+    bio.xpath('//table/tr/td/a[contains(@href, "mailto")]').map(&:text).map(&:tidy).join(';')
   end
 
   field :website do

diff --git a/test/cassettes/lct_htm.yml b/test/cassettes/lct_htm.yml
diff --git a/test/data/lct.htm.yml b/test/data/lct.htm.yml
@@ -0,0 +1,19 @@
+---
+:class: MemberPage
+:url: http://www.legco.gov.hk/general/english/members/yr16-20/lct.htm
+:to_h:
+  :id: yr16-20/lct
+  :term: yr16-20
+  :name: LAM Cheuk-ting
+  :honorific_prefix: Hon
+  :honorific_suffix: ''
+  :gender:
+  :faction: Democratic Party
+  :email: [email protected];[email protected];[email protected]
+  :website: ''
+  :phone: 3611 0266 / 2650 0040
+  :fax: 3705 9822 / 2650 0955
+  :img: http://www.legco.gov.hk/images/mem_1620/lct.jpg
+  :area: New Territories East
+  :area_type: geographical
+  :source: http://www.legco.gov.hk/general/english/members/yr16-20/lct.htm