Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hong Kong: Sixth Legislative Council -- multiple emails and phone numbers need splitting #33726

Open
ondenman opened this issue Apr 24, 2017 · 0 comments
Open

Hong Kong: Sixth Legislative Council -- multiple emails and phone numbers need splitting #33726

ondenman opened this issue Apr 24, 2017 · 0 comments
Labels
broken scraper

Comments

@ondenman
Copy link
Contributor

Problem

The scraper is currently capturing multiple email addresses and phone numbers for members as one long string.

screen shot 2017-04-24 at 16 25 02

Fix

These need splitting and joining with a semicolon.
This was referenced Apr 24, 2017
Closed
Closed
This was referenced May 18, 2017
Open
Closed
ondenman pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue May 18, 2017
Test member with undelimited email addresses
316f8e2 
Member has multiple email addresses. The scraper is recording these without splitting them.

TODO: They need to be split with ';'s. Issue: everypolitician/everypolitician-data#33726
ondenman pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue Jun 5, 2017
Test member with gender data
20e3951 
TODO: The member has multiple phone numbers recorded without a delimiter:
everypolitician/everypolitician-data#33726
ondenman pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue Jun 5, 2017
Test member with undelimited email addresses
63f9a54 
Member has multiple email addresses. The scraper is recording these without splitting them.

TODO: They need to be split with ';'s. Issue: everypolitician/everypolitician-data#33726
ondenman pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue Jul 7, 2017
Test member with gender data
98ad44b 
TODO: The member has multiple phone numbers recorded without a delimiter:
everypolitician/everypolitician-data#33726
ondenman pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue Jul 7, 2017
Test member with undelimited email addresses
0c7435e 
Member has multiple email addresses. The scraper is recording these without splitting them.

TODO: They need to be split with ';'s. Issue: everypolitician/everypolitician-data#33726
ondenman pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue Jul 7, 2017
Test member data with gender
72fc7d1 
TODO: The member has multiple phone numbers recorded without a delimiter:
everypolitician/everypolitician-data#33726
ondenman pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue Jul 7, 2017
Test member data with undelimited email addresses
51d4cab 
Member has multiple email addresses. The scraper is recording these without splitting them.

TODO: They need to be split with ';'s. Issue: everypolitician/everypolitician-data#33726
ondenman pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue Jul 7, 2017
Join multiple email addressess with semi-colons
ea0a9ea 
Some members have multiple email addresses. Previously MemberPage was capturing them joined as one contiguous string. With this commit, multiple email addresses are now delimited with semi-colons.

Fixes everypolitician/everypolitician-data#33726
@ondenman ondenman mentioned this issue Jul 7, 2017
Open
tmtmtmtm pushed a commit to everypolitician-scrapers/hong_kong_legislative_council_members that referenced this issue Jul 14, 2017
@tmtmtmtm
Join multiple email addressess with semi-colons
e7fff48 
Some members have multiple email addresses. Previously MemberPage was capturing them joined as one contiguous string. With this commit, multiple email addresses are now delimited with semi-colons.

Fixes everypolitician/everypolitician-data#33726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken scraper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ondenman