Delimit multiple email addresses with semi-colons #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 7, 2017 10:35
This class represents a document listing members of the legislature.
The scraper now conforms to rubocop.
TODO: The member has multiple phone numbers recorded without a delimiter: everypolitician/everypolitician-data#33726
Instead of recording the url of the member's portrait, the scraper is getting the URL of a PDF icon. Issue: everypolitician/everypolitician-data#33716
|
This is intended to be merged with #9 but |
tmtmtmtm
force-pushed
the
delimit-email-addresses
branch
from
83db902
to
17e2ad4
Compare
Some members have multiple email addresses. Previously MemberPage was capturing them joined as one contiguous string. With this commit, multiple email addresses are now delimited with semi-colons.
tmtmtmtm
force-pushed
the
delimit-email-addresses
branch
from
17e2ad4
to
6b307bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some members have multiple email addresses. Previously MemberPage was capturing them joined as one contiguous string. With this commit, multiple email addresses are now delimited with semi-colons.
Fixes everypolitician/everypolitician-data#33726