Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delimit multiple email addresses with semi-colons #11

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Delimit multiple email addresses with semi-colons #11

wants to merge 9 commits into from

Commits on Jul 7, 2017

  1. Extract MembersPage 

    This class represents a document listing members of the legislature.
    Oliver Denman committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    569e473 View commit details
    Browse the repository at this point in the history

  2. Extract MemberPage

    Oliver Denman committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    b58c82e View commit details
    Browse the repository at this point in the history

  3. Clear out rubocop todo 

    The scraper now conforms to rubocop.
    Oliver Denman committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    90c376d View commit details
    Browse the repository at this point in the history

  4. Test member data without gender

    Oliver Denman committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    42eb114 View commit details
    Browse the repository at this point in the history

  5. Test member data with gender 

    TODO: The member has multiple phone numbers recorded without a delimiter:
everypolitician/everypolitician-data#33726
    Oliver Denman committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    72fc7d1 View commit details
    Browse the repository at this point in the history

  6. Test member data with non-party group

    Oliver Denman committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    b65e4fd View commit details
    Browse the repository at this point in the history

  7. Test independent member

    Oliver Denman committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    758a460 View commit details
    Browse the repository at this point in the history

  8. Test member data with broken image 

    Instead of recording the url of the member's portrait, the scraper is getting the URL of a PDF icon.

Issue: everypolitician/everypolitician-data#33716
    Oliver Denman committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    e66515f View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2017

  1. Join multiple email addressess with semi-colons 

    Some members have multiple email addresses. Previously MemberPage was
capturing them joined as one contiguous string. With this commit,
multiple email addresses are now delimited with semi-colons.
    @tmtmtmtm
    Oliver Denman authored and tmtmtmtm committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    6b307bf View commit details
    Browse the repository at this point in the history