Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Page::TermTable class #15613

Merged
merged 2 commits into from
Feb 23, 2017

Conversation

chrismytton
Copy link
Contributor

What does this do?

Adds YARD documentation for the Page::TermTable class.

Why was this needed?

This is part of the bigger effort to document all classes in this app (#15310).

Relevant Issue(s)

Part of #15310

This change should make #15606 a bit easier to document.

Screenshots

page-term-table-yard

This adds YARD documentation for the `Page::TermTable` class as part of
the bigger push to get this whole application documented.
@tmtmtmtm tmtmtmtm temporarily deployed to everypolitician-viewe-pr-15613 February 23, 2017 12:26 Inactive
Copy link
Contributor

@tmtmtmtm tmtmtmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo that you should do a quick fixup for, but otherwise 👍 as a good start for this.

@@ -55,6 +77,8 @@ def group_data
@group_data
end

# A list of people that held a memberships at some point during this term
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "a memberships"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks! Fixed in 258b63a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants