Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Replace root div element with Fragment #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace root div element with Fragment #27

wants to merge 3 commits into from

Conversation

RusinovAnton
Copy link

My use case for instance

<div style={{ display: 'flex' }}>{
  withPropsCombinations(MyComponent, { ...propCombinations })
}</div>

evgenykochetkov
evgenykochetkov suggested changes Mar 30, 2018
View reviewed changes
Copy link
Owner

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but please remove package-lock.json. It's giant and not related to the PR.

package.json
"react": "^15.6.2",
"react-dom": "^15.6.2"
"react": "^16.2.0",
"react-dom": "^16.2.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should peerDependencies be updated to ^16.x only? 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

@evgenykochetkov
Copy link
Owner

Also, this probably solves #22 👍🏻

@mikeduminy
Copy link

Would love this to land so the addon can be used in react-native

@RusinovAnton
Copy link
Author

Sorry. I did totally forgot about this work. @evgenykochetkov please review this again when you have a minute.

@mikeduminy
Copy link

Thanks @RusinovAnton

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evgenykochetkov evgenykochetkov evgenykochetkov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RusinovAnton @evgenykochetkov @mikeduminy