Skip to content

Commit

Permalink
fix(Runtime): Change Node version to 16 (LLC-2306) (LearningLocker#889)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Upgrade Node version runtime from v14 to v16
  • Loading branch information
lucuilearningpool authored Feb 28, 2023
1 parent 6ec45a1 commit 4f01c77
Show file tree
Hide file tree
Showing 5 changed files with 789 additions and 89 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
cache: 'yarn'

- name: Installing Dependencies
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
cache: 'yarn'

- name: Installing Dependencies
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
cache: 'yarn'

- name: Installing Dependencies
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
cache: 'yarn'

- name: Installing Dependencies
Expand Down Expand Up @@ -238,7 +238,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
cache: 'yarn'

- name: Installing Dependencies
Expand Down Expand Up @@ -271,7 +271,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
cache: 'yarn'

- name: Installing Dependencies
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:14
FROM node:16
ENV NPM_CONFIG_LOGLEVEL warn
WORKDIR /usr/src/app

Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@
"postinstall": "patch-package"
},
"engines": {
"node": ">6.0.0",
"npm": ">3.0.0"
"node": ">16.0.0",
"npm": ">8.0.0"
},
"dependencies": {
"@aws-sdk/client-s3": "^3.100.0",
"@aws-sdk/lib-storage": "^3.100.0",
"@azure/storage-blob": "^10.3.0",
"@google-cloud/storage": "^5.8.1",
"@learninglocker/xapi-validation": "^2.1.10",
"@learninglocker/xapi-validation": "^4.0.0",
"accept-language-parser": "^1.5.0",
"atob": "^2.0.3",
"bluebird": "3.7.2",
Expand All @@ -56,7 +56,7 @@
"http-status-codes": "^2.0.0",
"install": "^0.13.0",
"ioredis": "^4.14.0",
"jscommons": "^4.0.0",
"jscommons": "^6.0.0",
"jsonwebtoken": "^8.5.1",
"lodash": "^4.17.4",
"mime-types": "2.1.35",
Expand Down Expand Up @@ -88,7 +88,7 @@
"@types/lodash": "4.14.176",
"@types/mime-types": "2.1.1",
"@types/mocha": "8.2.3",
"@types/node": "^14.18.18",
"@types/node": "16.18.13",
"@types/node-fetch": "2.5.8",
"@types/object-hash": "1.3.4",
"@types/redis": "2.8.32",
Expand Down
2 changes: 1 addition & 1 deletion test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ git clone -b master https://github.com/adlnet/lrs-conformance-test-suite ../conf
cd ../conformance

log "Installing dependencies for the ADL conformance test suite."
npm ci
yarn install --ignore-engines --frozen-lockfile

log "Running the ADL conformance test suite."
node bin/console_runner.js -e "http://localhost:$EXPRESS_PORT/data/xAPI" -a -u "AAA" -p "BBB" -b
Expand Down
Loading

0 comments on commit 4f01c77

Please sign in to comment.