fix s3 persistence load issue where it created two challengers

eviltester · Mar 9, 2024 · 327e20f · 327e20f
1 parent 5f25155
commit 327e20f
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/challenger/src/main/java/uk/co/compendiumdev/challenge/persistence/PersistenceLayer.java b/challenger/src/main/java/uk/co/compendiumdev/challenge/persistence/PersistenceLayer.java
@@ -4,7 +4,6 @@
 import uk.co.compendiumdev.challenge.ChallengerState;
 import uk.co.compendiumdev.challenge.challengers.Challengers;
 import uk.co.compendiumdev.thingifier.api.ermodelconversion.JsonPopulator;
-import uk.co.compendiumdev.thingifier.core.EntityRelModel;
 import uk.co.compendiumdev.thingifier.core.domain.instances.ERInstanceData;
 
 public class PersistenceLayer {
@@ -29,8 +28,7 @@ public PersistenceResponse tryToLoadChallenger(final Challengers challengers,
         final PersistenceResponse response = loadChallengerStatus(xChallengerGuid);
 
         if(response.isSuccess()){
-            ChallengerAuthData challenger = challengers.createNewChallenger();
-            challenger.fromData(response.getAuthData(), challengers.getDefinedChallenges());
+            ChallengerAuthData challenger = new ChallengerAuthData(challengers.getDefinedChallenges()).fromData(response.getAuthData(), challengers.getDefinedChallenges());
             if(xChallengerGuid.equals(Challengers.SINGLE_PLAYER_GUID)){
                 challenger.setXChallengerGUID(xChallengerGuid);
             }