Dev fix 15 #17
Draft
Dev fix 15 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evnu
reviewed
Nov 14, 2022
| @@ -0,0 +1,25 @@ | |||
| defprotocol Compare do | |||
There was a problem hiding this comment.
We can implement a protocol only once per type, correct? That might be a problem when trying to have closed intervals with different order in the same VM.
There was a problem hiding this comment.
That is actually something I use: I have a project with different ord implementations on the same type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic draft proposal for #15. Quite some code can be deleted. I find the custom order also very nice. It seems that this refactoring has uncovered a bug, #16 .
To dos
Compare