Add a more reliable way to compute image sizes #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original approach was always hacky, and indeed it breaks down for certain types of images. I found that when encoding an 8-bit palette BMP as RGBA with a lot of duplicated colors, the duplicated pixels will cause the resulting BMP file to exceed the computed maximum size.
It's inferior to the replacement in every way. Good riddance?
rdw-software
force-pushed
the
stbi-size-computation
branch
from
35c9e3f
to
dbaa58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original approach was always hacky, and indeed it breaks down for certain types of images. I found that when encoding an 8-bit palette BMP as RGBA with a lot of duplicated colors, the duplicated pixels will cause the resulting BMP file to exceed the computed maximum size.