Update RML to the latest HEAD #587
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
force-pushed
the
rml-update-latest
branch
from
46d0f17
to
6fdba28
Compare
|
Also worth investigating: Why on earth does the build not fail if the LuaJIT CMake variable is now ignored? Maybe CMake "magically" finds it, in which case there's no telling whether it found the right version. I didn't see any errors or even warnings while building, which is perplexing - I'd expect the unused variables to cause a warning (or, even better, fail the build process)? |
rdw-software
changed the title
rdw-software
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT the 6.0 changes have already been accounted for last time the module was updated. Still, review again - just in case.
Edit: That's not correct; there are many breaking changes that don't seem to have been considered yet. Deferring this..
Note to self: DO NOT MERGE until the version mismatch has been fixed! See #589 for details.