Rspec puppet pin #12
Open
Rspec puppet pin #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to work around duplicate resource issues when you have
settings of different types with the same name. When the files are built
it is path/${priority}${base_name}${extension}.
Allow priorities to be zero-padded
Add base_name parameter to apt::setting
Add them to PPA since they were being used there, and add a placeholder example for setting up the proxy files.
This adds consistency across the module
Convert to use apt::setting instead of file resource
proxy_* params were removed from class apt
Instead of having two additional parameters, `base_name` and `setting_type` simply parse it from `title`. We need to prefix most resources with `list-`, `conf-`, or `pref-` any way to avoid duplicate resources so we might as well leverage that.
apt::setting: Parse type and name from title.
Can be disabled by setting `notify_update => false`
Make apt::setting notify Exec['apt_update'] by default
Most options can and should be named through symbols, makes it much easier to read too with syntax highlighting.
Re-introduce proxy support at the class level. Needing to configure a proxy is such a common scenario that having it on the class is a reasonable thing. It also affects `apt::ppa`. Change `apt::ppa` to no longer have its own `proxy` parameter but use the proxy as configured on the main `apt` class.
apt: Add proxy support on the class.
* Instead of having 4 options controlling purging we now have a single hash with four possible keys. * We purge everything by default. * `/etc/apt/preferences` is now always managed. * Add missing `mode` to some of the files.
* Instead of having 4 options controlling purging we now have a single hash with four possible keys. * Include `apt::update` only _after_ we've assembled the `$_update` hash.
* Allow any configuration of apt to be done through data bindings by passing in hashes representing the resources. * Switch apt::ppa to use `distid` as set in `apt::params. This makes `apt::ppa` also work for LinuxMint.
Remove a lot of the redundant `key_` prefixes on `apt::key` and the `keyserver_` prefix on `apt_key`.
Turn `$key` into something that accepts a string or a hash of four keys representing the different options that can be passed on to `apt::key`.
The behaviour of passing down undef through multiple layers gets fuzzy so for now be explicit about the keyserver. Once Puppet 4 is out and this behaviour has been crystallised and tested we can revisit it.
It's been a long time - how have you been
This was a great idea but is pretty pointless. It's also not being used by anything and not exposed as a switch on the main class so it would almost never affect any behaviour.
apt::setting: Remove file_perms.
A few of these fixes are absolutely horrendous but we have no choice as we need to stay current- and future-parser compatible for now. Once we can go Puppet 4 only we can use the `$facts` hash lookup instead which will return undef/nil for things that aren't set instead of them not being defined at all.
apt: Fix all strict variable cases.
`$xfacts` now contains and guards all `lsb*` facts. Looking up any `lsb*`-related fact should now always be done through `$::apt::xfacts` to ensure that the values are always set to either the value of the fact or undef. This avoids all sorts of kerfuffles with strict variables.
apt::params: Complete $xfacts.
This makes its behaviour similar to the `update`, `proxy` and `purge` hashes on the main classes bringing its API more in line with the rest of the module.
apt::source: Merge `include_*` options into hash.
Mergeback 2.2.x
MODULES-2861: run stages limitation added to the documentation.
fix whitespace in source.list
Add ubuntu 15.10 support
…tion Fix apt_key tempfile race condition
It looks like add-apt-repository changes pluses to underscores when creating the sources.list.d file. So the name it creates doesn't match what Puppet expects, and the resource keeps applying on every Puppet run. This works around that problem.
Handle PPA names that contain a plus character.
(FM-4049) update to modulesync_configs
MODULES-2941: add example to README
MODULES-2873 - Avoid multiple package resource declarations
"man apt-add-repository" notes: "REPOSITORY can be either a line that can be added directly to sources.list(5), in the form ppa:<user>/<ppa-name> for adding Personal Package Archives". Fix the tests to always use the format ppa:<user>/<ppa-name> when adding PPAs.
In Ubuntu 15.10 the path of the apt sources file, which is generated by apt-add-repository, changed to include the distid. This breaks apt::ppa idempotency, since it does not recognize the repository is already added. Reported on puppet-users as well: https://groups.google.com/forum/#!topic/puppet-users/YzeMyZYUo98
Look for correct sources.list.d file for apt::ppa
This moves all copyright statements to the NOTICE file in accordance with the ASFs guidelines on applying the Apache-2.0 license.
(FM-4046) Update to current msync configs [006831f]
Update metadata to note Debian 8 support
Prep for 2.2.2 Release
Mergeback 2.2.x
Typo: missing colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a temporary measure, as once module-sync runs, this file will be overwritten. This is to make the rspec tests go green until we add support for rspec_puppet 2.4.0