This repository has been archived by the owner on Jun 11, 2019. It is now read-only.
new format for setting os/version specific params #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| case $::osfamily { | ||
| 'Debian', 'Ubuntu', 'Mint': { |
There was a problem hiding this comment.
If we use osfamily, 'Debian' is enough
|
Besides the commented parts, it looks ok to me. Would you fix them? |
koglinjg
force-pushed
the
feature_update_params
branch
from
af2ba09
to
9fb983d
Compare
|
Fixed and rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6, I have made some significant changes in terms of style and a bit around how it works for the end user. Please review this carefully.
If you don't like the idea of the puppet apply failing and would rather have the generic default values, let me know and I can put those back. I just think this provides a higher quality of module as you know with more certainty that this will work for everyone that uses it. If it fails with an unsupported OS, they can submit an issue and provide the service name, package name, etc that is appropiate for that os/version.