Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution to more cases for cross part #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add solution to more cases for cross part #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fca854
Add solution to cases where the two parts for the cross part are not …
ondrasy Jan 8, 2024
206808a
Fix a typo in the comment.
ondrasy Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lasercut/crosspart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,22 @@ def make_cross_parts(parts):
and not first_face_second_shape and second_face_second_shape:
#print str_parts_name + " : a part is above the other (2)"
remove_intersections(first_part, second_part, referential_faces, axis, True)
elif not first_face_first_shape and not second_face_first_shape \
and first_face_second_shape and not second_face_second_shape:
# Case where face 2 is common base and shape 2 is higher
remove_intersections(first_part, second_part, referential_faces, axis)
elif first_face_first_shape and not second_face_first_shape \
and not first_face_second_shape and not second_face_second_shape:
# Case where face 2 is common base and shape 1 is higher
remove_intersections(first_part, second_part, referential_faces, axis, True)
elif not first_face_first_shape and second_face_first_shape \
and not first_face_second_shape and not second_face_second_shape:
# Case where face 1 is common base and shape 1 is higher
remove_intersections(first_part, second_part, referential_faces, axis)
elif not first_face_first_shape and not second_face_first_shape \
and not first_face_second_shape and second_face_second_shape:
# Case where face 1 is common and shape 2 is higher
remove_intersections(first_part, second_part, referential_faces, axis, True)
else:
raise ValueError("Not managed")

Expand Down