Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knapsack #945

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Add knapsack #945

merged 4 commits into from
Feb 24, 2024

Conversation

ryanplusplus
Copy link
Member

Related to #940

@ryanplusplus ryanplusplus mentioned this pull request Jan 28, 2024
12 tasks
Copy link
Contributor

@siebenschlaefer siebenschlaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case you were waiting for a review: Looks great!
(I don't think I have the power to approve here on the C track.)

The only tiny suggestion from me is this:
In the first test you could consider defining variables items and item_count, just like in the other tests, because the students have to extract the signature and semantics of the function maximum() from the tests and I think that's easier with maximum(maximum_weight, items, item_count) than with maximum(maximum_weight, NULL, 0).

@ryanplusplus
Copy link
Member Author

Just in case you were waiting for a review: Looks great! (I don't think I have the power to approve here on the C track.)

The only tiny suggestion from me is this: In the first test you could consider defining variables items and item_count, just like in the other tests, because the students have to extract the signature and semantics of the function maximum() from the tests and I think that's easier with maximum(maximum_weight, items, item_count) than with maximum(maximum_weight, NULL, 0).

Good point, I'll change that.

@ryanplusplus
Copy link
Member Author

Just in case you were waiting for a review: Looks great! (I don't think I have the power to approve here on the C track.)

Thanks for the review!

@wolf99 wolf99 merged commit 4a6251e into main Feb 24, 2024
4 checks passed
@wolf99 wolf99 deleted the knapcsack branch February 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants