Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run-test for macOS standard tools #948

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Fix run-test for macOS standard tools #948

merged 2 commits into from
Jan 29, 2024

Commits on Jan 28, 2024

  1. Fix run-test for macOS standard tools 

    BSD sed requires an argument with `-i` (backup file extension, disabling
backup file creation by providing an empty string; this is the default for GNU
sed when `-i` is specified without an argument).

Further, `/bin/bash` shipping with macOS 14 doesn't like `${*}` when the
argument list is empty (at least in the context it is used in `run-tests`).
The fix of having a distinct message for the case where `${*}` is empty also
improves the behavior for cases where a version of Bash is used that does not
complain about an empty `${*}`.

This has been tested on macOS Sonoma 14.3, but probably also applies to earlier
versions.
    @ahans
    ahans committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    05309af View commit details
    Browse the repository at this point in the history

  2. Fix run-tests example

    @ahans
    ahans committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    8f781d0 View commit details
    Browse the repository at this point in the history