Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically push Docker image to Docker Hub #10

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Conversation

ErikSchierboom
Copy link
Member

The v3 development environment uses Docker images from Docker Hub for all the tooling.
This allows for easy testing of the various tooling components (analyzers/representer/test-runners).

This PR adds a GitHub Actions workflow to automatically build and push a new Docker image whenever something is merged to master.

See exercism/v3#2727

@verdammelt
Copy link
Member

@ErikSchierboom I think we already have this docker hub action for this project. https://github.com/exercism/common-lisp-analyzer/blob/master/.github/workflow/dockerhub.yml

@ErikSchierboom
Copy link
Member Author

@verdammelt At first I was like: damn, was there a bug in my script? But then I noticed that the existing file is in the wrong folder: workflow instead of the correct workflows. :)

The version in this PR also has the advantage that it is repository agnostic (the repo name is parameterized), although admittedly that's a rather academic advantage as it is unlikely that we ever change this repo name.

@verdammelt
Copy link
Member

workflow vs workflows - UGH.

I'd like to add removing the wrong one to this PR - but then will happily merge it. (should be able to do that later today...)

@ErikSchierboom
Copy link
Member Author

Great!

@verdammelt verdammelt merged commit d50d827 into master Nov 6, 2020
@verdammelt verdammelt deleted the ci-dockerhub branch November 6, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants