ci: add /WX (warnings as errors) compile flag when compiling with MSV…

…C. (#923) * Add /WX (warnings as errors) compile flag when compiling with MSVC. * Call darts::score() with floats instead of doubles to get rid of C4305. * Suppress C4244 and C4267 because lots of code triggers them and GCC and CLang are fine with those conversions. * Add missing endif to CMakeLists.txt for sieve.
exercism · Nov 3, 2024 · 19bef29 · 19bef29
1 parent 3d106a5
commit 19bef29
Show file tree

Hide file tree

Showing 96 changed files with 391 additions and 106 deletions.
diff --git a/exercises/concept/doctor-data/CMakeLists.txt b/exercises/concept/doctor-data/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/election-day/CMakeLists.txt b/exercises/concept/election-day/CMakeLists.txt
@@ -58,9 +58,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/ellens-alien-game/CMakeLists.txt b/exercises/concept/ellens-alien-game/CMakeLists.txt
@@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/freelancer-rates/CMakeLists.txt b/exercises/concept/freelancer-rates/CMakeLists.txt
@@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/interest-is-interesting/CMakeLists.txt b/exercises/concept/interest-is-interesting/CMakeLists.txt
@@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/lasagna-master/CMakeLists.txt b/exercises/concept/lasagna-master/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/lasagna/CMakeLists.txt b/exercises/concept/lasagna/CMakeLists.txt
@@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/last-will/CMakeLists.txt b/exercises/concept/last-will/CMakeLists.txt
@@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/log-levels/CMakeLists.txt b/exercises/concept/log-levels/CMakeLists.txt
@@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/making-the-grade/CMakeLists.txt b/exercises/concept/making-the-grade/CMakeLists.txt
@@ -58,9 +58,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/pacman-rules/CMakeLists.txt b/exercises/concept/pacman-rules/CMakeLists.txt
@@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/troll-the-trolls/CMakeLists.txt b/exercises/concept/troll-the-trolls/CMakeLists.txt
@@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/concept/vehicle-purchase/CMakeLists.txt b/exercises/concept/vehicle-purchase/CMakeLists.txt
@@ -60,9 +60,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/acronym/CMakeLists.txt b/exercises/practice/acronym/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/all-your-base/CMakeLists.txt b/exercises/practice/all-your-base/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/allergies/CMakeLists.txt b/exercises/practice/allergies/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/anagram/CMakeLists.txt b/exercises/practice/anagram/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/armstrong-numbers/CMakeLists.txt b/exercises/practice/armstrong-numbers/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/atbash-cipher/CMakeLists.txt b/exercises/practice/atbash-cipher/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/bank-account/CMakeLists.txt b/exercises/practice/bank-account/CMakeLists.txt
@@ -59,9 +59,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/beer-song/CMakeLists.txt b/exercises/practice/beer-song/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/binary-search-tree/CMakeLists.txt b/exercises/practice/binary-search-tree/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/binary-search/CMakeLists.txt b/exercises/practice/binary-search/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/binary/CMakeLists.txt b/exercises/practice/binary/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/bob/CMakeLists.txt b/exercises/practice/bob/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/circular-buffer/CMakeLists.txt b/exercises/practice/circular-buffer/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/clock/CMakeLists.txt b/exercises/practice/clock/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build

diff --git a/exercises/practice/collatz-conjecture/CMakeLists.txt b/exercises/practice/collatz-conjecture/CMakeLists.txt
@@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS})
 endif()
 
 # Tell MSVC not to warn us about unchecked iterators in debug builds
+# Treat warnings as errors
+# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3
 if(${MSVC})
     set_target_properties(${exercise} PROPERTIES
-        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS)
+        COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS
+        COMPILE_FLAGS "/WX /w44244 /w44267")
 endif()
 
 # Run the tests on every build