Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve wording for header concept #731

Merged
merged 2 commits into from
Oct 29, 2023
Merged

docs: improve wording for header concept #731

merged 2 commits into from
Oct 29, 2023

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Oct 19, 2023

Reduces the "advice" character of the class section and gives two examples instead.

@vaeng vaeng added x:action/proofread Proofread text x:type/docs Work on Documentation labels Oct 19, 2023
@vaeng vaeng requested a review from siebenschlaefer October 19, 2023 08:22
siebenschlaefer
siebenschlaefer reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@siebenschlaefer siebenschlaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

concepts/headers/about.md Outdated Show resolved Hide resolved
@vaeng vaeng merged commit d826ea9 into main Oct 29, 2023
7 checks passed
@vaeng vaeng deleted the docs--improve-wording-for-header-concept branch October 29, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siebenschlaefer siebenschlaefer siebenschlaefer approved these changes

Assignees
No one assigned
Labels
x:action/proofread Proofread text x:type/docs Work on Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaeng @siebenschlaefer