Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve troll-the-trolls, task 2 #828

Merged

Conversation

siebenschlaefer
Copy link
Contributor

  • modified the instructions, hopefully they are now easier to understand.
  • moved the test "Troll posts are visible to non-trolls" up and fixed its title.
  • added a new test "Non-troll posts are visible to trolls"

fixes #792

- modified the instructions, hopefully they are now easier to
  understand.
- moved the test "Troll posts are visible to non-trolls" up and fixed
  its title.
- added a new test "Non-troll posts are visible to trolls"
Copy link
Contributor

github-actions bot commented Mar 3, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link

@krstopro krstopro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion.

Every post on the forums saves the `AccountStatus` of the poster in its metadata.
Make sure that the trolls can only interact with each other.
Every post on the forums saves the `AccountStatus` of the poster in its metadata.
Make sure that posts by trolls are only displayed to other trolls.
Copy link

@krstopro krstopro Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write "the posts", just for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand. Do you mean "... that the posts by trolls ..." instead of "... that posts by trolls ..."?
In the rest of the document "the posts" (with a "the") does not appear, just "posts" alone, e.g. "can read posts", or with a possessive pronoun, e.g. "their posts are".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean "... that the posts by trolls ..." instead of "... that posts by trolls ..."?

Yeah, that is what I meant, but you can leave it as it is given that "the" doesn't appear before "posts" in the rest of the text, as you noticed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave that decision to @vaeng

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the less wordy version and would like to keep it without the

Every post on the forums saves the `AccountStatus` of the poster in its metadata.
Make sure that the trolls can only interact with each other.
Every post on the forums saves the `AccountStatus` of the poster in its metadata.
Make sure that posts by trolls are only displayed to other trolls.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the less wordy version and would like to keep it without the

@@ -22,6 +22,8 @@ Her strategy is to give them the illusion that their time is "well invested", bu
For anything that requires priority ordering, trolls are last in any sequence.
When they enter a game, the pool of available players is also limited to other trolls.

This practice is called [shadow-banning][shadow-ban].
Copy link
Contributor

@vaeng vaeng Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a link to add some context for users who don't know the concept.
I hope you don't mind.

@siebenschlaefer siebenschlaefer merged commit 776150d into exercism:main Mar 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak troll exercise
3 participants