Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add workflow to push Docker image to Dockerhub and ECR #35

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

ErikSchierboom
Copy link
Member

This PR adds a GitHub Actions workflow to automatically push a new version of this repo's Docker image to both Dockerhub and ECR.
The former is used when running the tooling on your local machine using the development environment, the latter is currently used when running the tooling on our staging environment (https://exercism.lol/) but will eventually be used for our production website.

We've sent PRs to tooling repos before related to this functionality, but those PRs added two separate workflows for pushing to Dockerhub and ECR. With this PR, these workflows have been merged into a single workflow, which is much more efficient. If present, the old workflows will be removed in this PR.

See exercism/v3#2969

Copy link
Member

@angelikatyborska angelikatyborska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what's going on so I'll just trust you and approve.

@ErikSchierboom
Copy link
Member Author

I have no idea what's going on so I'll just trust you and approve.

Lol! Let me know if you want me to explain :)

@ErikSchierboom ErikSchierboom merged commit d17964e into master Jan 8, 2021
@ErikSchierboom ErikSchierboom deleted the docker-workflow branch January 8, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants