Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Elixir 1.12 #1504

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Drop Elixir 1.12 #1504

merged 5 commits into from
Jul 12, 2024

Conversation

angelikatyborska
Copy link
Member

@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?

  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?

  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

jiegillet
jiegillet reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@jiegillet jiegillet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for doing the work!

I grepped for "1.10" and saw a couple more places that we could clean up (in exercises/concept/secrets/.meta/exemplar.ex, exercises/practice/bottle-song/mix.exs and exercises/practice/word-count/.meta/example.ex where we can replace frequencies() by Enum.frequencies()).

I grepped for "1.11" and saw a note in exercises/concept/paint-by-number/.docs/instructions.md we can clean up too.

bin/bootstrap_practice_exercise.exs Outdated
@@ -167,8 +167,7 @@ defmodule #{module}.MixProject do
[
app: :#{exercise_snake_case},
version: "0.1.0",
# elixir: "~> 1.10",
start_permanent: Mix.env() == :prod,
start_permanent: Mix.env() == :prod,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs formatting, it's not automated because it's a string.

exercises/concept/paint-by-number/.meta/exemplar.ex
@@ -4,7 +4,7 @@ defmodule PaintByNumber do
end

defp do_palette_bit_size(color_count, bits \\ 1) do
if Math.pow(2, bits) >= color_count do
if Integer.pow(2, bits) >= color_count do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@angelikatyborska
Copy link
Member Author

Fixed! thank you for finding the remaining problems 😇

jiegillet
jiegillet approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@jiegillet jiegillet merged commit 0973cb7 into main Jul 12, 2024
9 checks passed
@jiegillet jiegillet deleted the drop-elixir-1-12 branch July 12, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelikatyborska @jiegillet