-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine Take-A-Number #1511
Refine Take-A-Number #1511
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ You are writing an embedded system for a Take-A-Number machine. It is a very sim | |
|
||
## 1. Start the machine | ||
|
||
Implement the `start/0` function. It should spawn a new process that has an initial state of `0` and is ready to receive messages. It should return the process's PID. | ||
Implement the `start/0` function. It should spawn a new process and return the process's PID. The new process doesn't need to do anything yet. | ||
|
||
```elixir | ||
TakeANumber.start() | ||
|
@@ -15,12 +15,15 @@ Note that each time you run this code, the PID may be different. | |
|
||
## 2. Report the machine state | ||
|
||
Modify the machine so that it can receive `{:report_state, sender_pid}` messages. It should send its current state (the last given out ticket number) to `sender_pid` and then wait for more messages. | ||
Modify the machine so that the newly spawned process is ready to receive messages (start a _receive loop_) with an initial state of `0`. It should be able to receive `{:report_state, sender_pid}` messages. As a response to those messages, it should send its current state (the last given out ticket number) to `sender_pid` and then wait for more messages. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I hope that the phrase "receive loop" will remind people of the paragraph with the same title from the introductions There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you considered adding some example code in the receive loop section? I think code will make it a lot more memorable. Something like: def loop(ping_count) do
receive do
{:ping, sender_pid} ->
send(sender_pid, :pong)
loop(ping_count + 1)
end
end It's pretty close to the solution though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, many times, but it is clearly against the recommendation:
Defining a recursive function is not new syntax... |
||
|
||
```elixir | ||
machine_pid = TakeANumber.start() | ||
|
||
# a client sending a message to the machine | ||
send(machine_pid, {:report_state, self()}) | ||
|
||
# a client receiving a message from the machine | ||
receive do | ||
msg -> msg | ||
end | ||
Comment on lines
+22
to
29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are those comments helpful? I was staring at this snippet and I was afraid that people might not understand that this code is an example code of how to test the implementation of the machine, and not the code that should go into the implementation of the machine 🤔 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see your concern, but that's usually what those code snippets do. test "reports its own state" do
pid = TakeANumber.start()
send(pid, {:report_state, self()})
assert_receive 0
end but that might not help so much. |
||
|
@@ -34,8 +37,11 @@ Modify the machine so that it can receive `{:take_a_number, sender_pid}` message | |
|
||
```elixir | ||
machine_pid = TakeANumber.start() | ||
|
||
# a client sending a message to the machine | ||
send(machine_pid, {:take_a_number, self()}) | ||
|
||
# a client receiving a message from the machine | ||
receive do | ||
msg -> msg | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope those instructions are explicit enough to lead people to a solution similar to the exemplar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they should be