add circular-buffer, part of 48 in 24 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BNAndras
added
x:module/practice-exercise
|
@BNAndras I am not sure why this is failing CI. Any suggestions? |
|
I'll take a look later this week and let you know if I see anything amiss. |
|
Thanks. Think I have it. Had to (require 'eieio) in test file. |
|
Hold up on this. I need to make sure some tests check for a specific error message on some operations, instead of just that it throws an error. |
|
good to review now. |
BNAndras
reviewed
Jun 12, 2024
BNAndras
approved these changes
Jun 13, 2024
|
Looks good. If you rebase the PR to fix the merge conflict, I can merge the PR. |
|
should be ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.