Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

practice-exercise-generator: Don't include commas in test names #420

Merged

Conversation

fapdash
Copy link
Contributor

@fapdash fapdash commented Jun 19, 2024

fixes #419

@BNAndras BNAndras merged commit f55df54 into exercism:main Jun 19, 2024
2 checks passed
@fapdash fapdash deleted the remove-commas-for-generated-test-names branch June 19, 2024 20:44
kmarker1101 pushed a commit to kmarker1101/emacs-lisp that referenced this pull request Jun 24, 2024
BNAndras added a commit that referenced this pull request Jul 3, 2024
* add parallel-letter-frequency, part of 48 in 24

* practice-exercise-generator: Don't include commas in test names (#420)

fixes #419

* fix merge conflict

* fix json formating issue

* fix merge issue

* refactor to use parallism

* check if ci failure was a fluke

* fix ci failure

* add empty string check

* return hash-table, update difficulty

* cleanup, fix error

* add instructions.append

* Use extra file for subprocess code

* bin/test-examples: Handle testing of exercises with additional files

* Don't use additional solution file

* add BNAndras and fapdash as contributors

* Use printed representation for hash table (de)serialization

* Revert changes to `bin/test-examples`

See #422 (comment)

* refactor tests

* Typo fix

---------

Co-authored-by: FAP <[email protected]>
Co-authored-by: András B Nagy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate_practice_exercise
2 participants