Automatically push Docker image to Amazon ECR #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobbZ
approved these changes
Nov 5, 2020
|
May I ask why they are pushed to the docker hub and ECR? |
Other than the website load balancer, none of our internal AWS services have network access outside of AWS, so cannot reach DockerHub. |
|
Thanks for the explanation. This actually also reminded me to hit the merge button :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v3 website uses Docker images from Amazon ECR for all the tooling.
Each tooling repo should have a workflow to automatically push to Amazon ECR whenever something is merged to master.
This PR adds a GitHub Actions workflow to automatically build and push a new Docker image whenever something is merged to master.
See exercism/v3#2728