-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically push Docker image to Amazon ECR #21
Conversation
I'm not sure this template repository should be pushing to ECR, but I do agree that this workflow should be included here somehow... Perhaps we can include it and disable it somehow, then add to the instructions for using this repo how to enable it? |
Agreed. @SaschaMann what would be the best way to disable a workflow? |
Ask @iHiD to disable actions for this repo: https://github.com/exercism/generic-test-runner/settings/actions |
I'm ok with that. The unit test workflow for |
Do we also need to add instructions to https://github.com/exercism/generic-test-runner/blob/master/README.md to ping an admin to add AWS credentials to any new test-runner created from this template? |
That's a good idea. |
@iHiD As mentioned above (#21 (comment)), we need Github Actions disabled for this repository. Has that been done? |
Yes it has. |
Thanks @ErikSchierboom @iHiD @SaschaMann |
And thank you! |
The v3 website uses Docker images from Amazon ECR for all the tooling.
Each tooling repo should have a workflow to automatically push to Amazon ECR whenever something is merged to master.
This PR adds a GitHub Actions workflow to automatically build and push a new Docker image whenever something is merged to master.
See exercism/v3#2728