Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically push Docker image to Amazon ECR #21

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

ErikSchierboom
Copy link
Member

The v3 website uses Docker images from Amazon ECR for all the tooling.
Each tooling repo should have a workflow to automatically push to Amazon ECR whenever something is merged to master.

This PR adds a GitHub Actions workflow to automatically build and push a new Docker image whenever something is merged to master.

See exercism/v3#2728

@cmccandless
Copy link
Collaborator

I'm not sure this template repository should be pushing to ECR, but I do agree that this workflow should be included here somehow... Perhaps we can include it and disable it somehow, then add to the instructions for using this repo how to enable it?

@ErikSchierboom
Copy link
Member Author

Agreed. @SaschaMann what would be the best way to disable a workflow?

@SaschaMann
Copy link

Ask @iHiD to disable actions for this repo: https://github.com/exercism/generic-test-runner/settings/actions

@cmccandless
Copy link
Collaborator

I'm ok with that. The unit test workflow for pull_request doesn't actually run anything important.

@cmccandless
Copy link
Collaborator

Do we also need to add instructions to https://github.com/exercism/generic-test-runner/blob/master/README.md to ping an admin to add AWS credentials to any new test-runner created from this template?

@ErikSchierboom
Copy link
Member Author

That's a good idea.

@cmccandless
Copy link
Collaborator

@iHiD As mentioned above (#21 (comment)), we need Github Actions disabled for this repository. Has that been done?

@iHiD
Copy link
Member

iHiD commented Jan 4, 2021

Yes it has.

@cmccandless cmccandless merged commit e621cdb into master Jan 4, 2021
@cmccandless cmccandless deleted the ci-amazon-ecr branch January 4, 2021 15:10
@cmccandless
Copy link
Collaborator

Thanks @ErikSchierboom @iHiD @SaschaMann

@iHiD
Copy link
Member

iHiD commented Jan 4, 2021

And thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants