Rework unit tests #124
Merged
Rework unit tests #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to conflict with #122 by the way, I would suggest merging that one first, and I'll fix the damage here afterwards. |
manumafe98
approved these changes
Feb 4, 2024
|
@ErikSchierboom could you review this one please? |
ErikSchierboom
approved these changes
Feb 14, 2024
# Conflicts: # src/main/java/analyzer/exercises/hamming/HammingAnalyzer.java # src/main/java/analyzer/exercises/twofer/TwoferAnalyzer.java # src/test/java/analyzer/exercises/hamming/HammingAnalyzerTest.java # src/test/java/analyzer/exercises/twofer/TwoferAnalyzerTest.java # src/test/resources/scenarios/hamming/DoesNotThrowInConstructor.java # src/test/resources/scenarios/hamming/NoCalculationOfHammingDistance.java # src/test/resources/scenarios/hamming/NoConditionalInConstructor.java # src/test/resources/scenarios/hamming/NoConstructor.java # src/test/resources/scenarios/twofer/NoConditionalLogic.java # src/test/resources/scenarios/twofer/UsesLambda.java # src/test/resources/scenarios/twofer/UsesLoop.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the unit tests to use the Approvals library for some additional coverage in the JUnit tests. Now each test scenario acts more or less like an integration test for each exercise instead of unit test for a specific analyzer. There is some overlap with the smoke tests this way, but the way I see it we can use these JUnit integration-style tests to cover (most of) all branches and possible approaches, and keep the number of smoke tests a bit smaller.