Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement analyzer for salary-calculator after revert #157

Merged

Conversation

manumafe98
Copy link
Contributor

@manumafe98 manumafe98 commented Mar 29, 2024

closes #111

Todo:

@manumafe98 manumafe98 added the x:size/medium Medium amount of work label Mar 29, 2024
@manumafe98 manumafe98 self-assigned this Mar 29, 2024
@manumafe98 manumafe98 requested a review from a team as a code owner March 29, 2024 17:05
@manumafe98
Copy link
Contributor Author

Just in case, do not merge until the website-copy comments are merged as well!

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! One small suggestion to make the code a bit more readable, feel free to address it if you want. Otherwise, fine to merge as-is! 👍

... As soon as the copy is merged as well, of course 🙃

@manumafe98 manumafe98 merged commit 50d729d into main Apr 2, 2024
4 checks passed
@manumafe98 manumafe98 deleted the revert-156-revert-155-ImplementAnalyzerForSalaryCalculator branch April 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/medium Medium amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

salary-calculator: implement analyzer
3 participants