Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment types #84

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Add comment types #84

merged 6 commits into from
Jan 19, 2024

Conversation

sanderploegsma
Copy link
Contributor

  • Added comment types to all existing comments
  • Updated the output writer to order comments based on their type: essential -> actionable -> informative -> celebratory -> <none>.

@sanderploegsma sanderploegsma requested a review from a team as a code owner January 19, 2024 14:14
@sanderploegsma
Copy link
Contributor Author

@ErikSchierboom question on the ordering: I'm assuming that the order of the comments in analysis.json is the order in which the feedback is presented to students? Or is there any internal ordering done by the platform?

@ErikSchierboom
Copy link
Member

I'm assuming that the order of the comments in analysis.json is the order in which the feedback is presented to students?

This is correct.

@sanderploegsma sanderploegsma merged commit c20b9ed into main Jan 19, 2024
2 checks passed
@sanderploegsma sanderploegsma deleted the add-comment-types branch January 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanderploegsma @ErikSchierboom