Removing isEmpty() comment from hamming analyzer

[manumafe98]

Fixes #94

The goal is to remove an old analyzer comment that after an exercise reformat is not useful anymore.

I guess is should open a PR to remove this from the website-copy right?

[manumafe98]

Sidenote: the gradlew.bat file changed alone, but it seems like is the same, I tried restoring the changes but does not seem to work for some reason.

[sanderploegsma]

Sidenote: the gradlew.bat file changed alone, but it seems like is the same, I tried restoring the changes but does not seem to work for some reason.

That's fine, I think the line endings were automatically converted by Git. No need to revert it!

[sanderploegsma]

I guess is should open a PR to remove this from the website-copy right?

Not strictly required, I believe there are some more templates there that are no longer being used. We need to do some housekeeping there anyway.

You are welcome to open a PR to remove the template though. If you do, we should make sure it's not merged before this PR.

[manumafe98]

It's normal that the pipeline is failing? there were two steps, a docker one, and the coverage one, or i'm missing something else? Thanks

[sanderploegsma]

It's normal that the pipeline is failing? there were two steps, a docker one, and the coverage one, or i'm missing something else? Thanks

The tests folder contains a couple of smoke tests for each exercise. It looks like the one in tests/hamming is expecting to receive the removed comment, see tests/hamming/expected_analysis.json. You can just update that file to no longer expect that comment to be present, and the smoke tests should turn green again.

[sanderploegsma]

As for the test coverage decreasing, that is expected since you removed some lines that were covered, so the overall coverage of the affected files drops with it. No need to worry about that.

[manumafe98]

It's normal that the pipeline is failing? there were two steps, a docker one, and the coverage one, or i'm missing something else? Thanks

The tests folder contains a couple of smoke tests for each exercise. It looks like the one in tests/hamming is expecting to receive the removed comment, see tests/hamming/expected_analysis.json. You can just update that file to no longer expect that comment to be present, and the smoke tests should turn green again.

Done!

[sanderploegsma]

Great stuff!