Fix broken test in Captains Log #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the end index of the randomShipRegistryNumber() so that the range goes from 1000 to 9999
There was a problem hiding this comment.
Great start, and I appreciate your willingness to try and contribute!
Unfortunately it looks like you made a small typo when updating CaptainsLog.java, see the inline comment.
Next to that the test class also needs updating. If you make sure to commit all changes to the same branch (called patch-1 in your copy of this repository) they should all end up in this same Pull Request. 👍
exercises/concept/captains-log/.meta/src/reference/java/CaptainsLog.java
Outdated
Show resolved
Hide resolved
Made changes to the Test file updating the expected values to (which are NCC-6258, NCC-1683 and NCC-4922 respectively).
Updated the typo of the end range to be 10000 instead of 11000
santialb
commented
Nov 28, 2023
sanderploegsma
approved these changes
Nov 28, 2023
sanderploegsma
changed the title
|
Congratulations with your first contribution @santialb! 🎉 |
|
Thanks for letting me help @sanderploegsma ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the end index of the randomShipRegistryNumber() so that the range goes from 1000 to 9999
Fixes #2589
Reviewer Resources:
Track Policies