Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve explanation on Java array .length property #2855

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

melonpan
Copy link
Contributor

@melonpan melonpan commented Nov 4, 2024

pull request

Hello! I've noticed the sentence "The most commonly used property for arrays is its length" might lead to some misunderstandings, as Java only has a single built-in direct property for arrays. To clarify this, I've made a small adjustment.

Changes made:

Replaced

"The most commonly used property for arrays is its length which can be accessed like this:"

with

"Java has a built-in length property that returns the length of an array, which can be accessed like this:".

Please let me know if you have any questions. Thanks in advance.


Reviewer Resources:

Track Policies

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think I agree with the general idea behind this change. I just have a suggestion for the wording.

In addition, could you also update the following files? They also describe the array length:

concepts/arrays/about.md Outdated Show resolved Hide resolved
@melonpan
Copy link
Contributor Author

melonpan commented Nov 4, 2024

Thanks for the suggestion, I've changed the wording and updated the files.

@kahgoh kahgoh added the x:rep/small Small amount of reputation label Nov 5, 2024
Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes looks good to me.

@kahgoh kahgoh merged commit a0eced9 into exercism:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants