-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grammar and clarity in reference types explanation #2856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out those errors and submitting a PR to fix them! I have a couple minor suggestions.
In addition, could you also update concepts/nullability/introduction.md and concepts/nullability/about.md? They have a similar problem.
Co-authored-by: Kah Goh <[email protected]>
Co-authored-by: Kah Goh <[email protected]>
@kahgoh Thank you for the comments have implemented your suggestions in all the files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those updates! I spotted a couple more inconsistencies though.
Co-authored-by: Kah Goh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Thanks for fixing this!
pull request
Small change to the grammar to make more sense.
Reviewer Resources:
Track Policies