Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar and clarity in reference types explanation #2856

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

armanh3k
Copy link
Contributor

@armanh3k armanh3k commented Nov 5, 2024

pull request

Small change to the grammar to make more sense.


Reviewer Resources:

Track Policies

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out those errors and submitting a PR to fix them! I have a couple minor suggestions.

In addition, could you also update concepts/nullability/introduction.md and concepts/nullability/about.md? They have a similar problem.

@armanh3k armanh3k requested a review from kahgoh November 6, 2024 14:30
@armanh3k
Copy link
Contributor Author

armanh3k commented Nov 6, 2024

@kahgoh Thank you for the comments have implemented your suggestions in all the files.

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those updates! I spotted a couple more inconsistencies though.

concepts/nullability/about.md Outdated Show resolved Hide resolved
concepts/nullability/about.md Outdated Show resolved Hide resolved
@armanh3k armanh3k requested a review from kahgoh November 7, 2024 11:50
Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Thanks for fixing this!

@kahgoh kahgoh merged commit 3369915 into exercism:main Nov 8, 2024
2 checks passed
@armanh3k armanh3k deleted the patch-1 branch November 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants