Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approach: nucleotide-count #607

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Approach: nucleotide-count #607

merged 3 commits into from
Oct 31, 2023

Conversation

ErwinOlie
Copy link
Contributor

This is my first approach contribution. Did I do this correctly? Feedback is welcome.

@ErwinOlie
Copy link
Contributor Author

ErwinOlie commented Oct 30, 2023 •
edited
Loading

@ErikSchierboom ready for review.

I haven't received reputation points for my previous PR (on the kotlin-test-runner). I have linked my GitHub account to my Exercism profile. Do I have to wait for a bit, or did I forget tags or something like that? Apparently I linked my GitHub to two different Exercism accounts at the same time. Logging in with GitHub resulted in a 500. After removing my old account I hope it works now.

ErikSchierboom
ErikSchierboom reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just a couple of tiny nits

exercises/practice/nucleotide-count/.approaches/groupby-plus/content.md Outdated Show resolved Hide resolved
exercises/practice/nucleotide-count/.approaches/groupby-plus/content.md Show resolved Hide resolved
exercises/practice/nucleotide-count/.approaches/introduction.md Outdated Show resolved Hide resolved
ErikSchierboom
ErikSchierboom approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@ErikSchierboom ErikSchierboom merged commit 1cecc0f into exercism:main Oct 31, 2023
2 checks passed
@ErikSchierboom
Copy link
Member

Merged. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErwinOlie @ErikSchierboom @ErwinOlie2