Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yacht's config.json to include the second required solution source file #693

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IndiGan
Copy link

@IndiGan IndiGan commented Jan 26, 2025

The exercise relies on the Yacht.kt file and this one depends on YachtCategory.kt file (which declares the utility enum class).

As of now, only Yacht.kt is included in the solution files array inside config.json.
This causes the two following errors :

  • HELP.md is not mentioning the correct command to submit the exercise (beginners using the Exercism CLI may not easily understand why tests are passing locally but not on the server) : exercism submit src/main/kotlin/Yacht.kt (currently) instead of exercism submit src/main/kotlin/Yacht.kt src/main/kotlin/YachtCategory.kt (corrected)
  • The shortcut command (exercism submit without any arguments) uses only Yacht.kt instead of passing both files

With the addition of YachtCategory.kt in the solution files, these two issues are fixed.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 26, 2025
@iHiD iHiD reopened this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants