-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add workflow to push Docker image to Dockerhub and ECR #37
Conversation
@ynfle It looks like you don't have review permissions for this repo. Would you be interested in having those permissions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - this PR also upgrades docker/build-push-action
to v2.
And it's great that this uses actions/cache
rather than satackey/action-docker-layer-caching
, which caused some CI errors previously (see https://github.com/exercism/nim-test-runner/runs/1382436417).
Approved, conditional on the docker/build-push-action
version number being fixed.
branches: [main, master] | ||
|
||
jobs: | ||
multiple-registries: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple-registries: | |
multiple-registries: |
Non-blocking comment: I think this name could be better.
Which permissions? Didn't I used to have permissions? |
Co-authored-by: ee7 <[email protected]>
Co-authored-by: ee7 <[email protected]>
Co-authored-by: ee7 <[email protected]>
Co-authored-by: ee7 <[email protected]>
Isn't it just because the nim-test-runner/.github/CODEOWNERS Line 1 in aba25f9
Maybe a member of that team has to approve even when the PR was created by somebody in that team?
From the GitHub API I can confirm that the permissions in this repo are:
|
This PR adds a GitHub Actions workflow to automatically push a new version of this repo's Docker image to both Dockerhub and ECR.
The former is used when running the tooling on your local machine using the development environment, the latter is currently used when running the tooling on our staging environment (https://exercism.lol/) but will eventually be used for our production website.
We've sent PRs to tooling repos before related to this functionality, but those PRs added two separate workflows for pushing to Dockerhub and ECR. With this PR, these workflows have been merged into a single workflow, which is much more efficient. If present, the old workflows will be removed in this PR.
See exercism/v3#2969