Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isbn-verifier #81

Merged
merged 3 commits into from
Nov 26, 2024
Merged

feat: add isbn-verifier #81

merged 3 commits into from
Nov 26, 2024

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Nov 26, 2024

No description provided.

@vaeng vaeng requested a review from ErikSchierboom November 26, 2024 11:44
@@ -0,0 +1,21 @@
~ "isbn-verifier.ua" ~ IsValid

⍤⤙≍ 1 IsValid "3-598-21508-8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you purposefully omitted the comments describing the test case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I have added them now.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one tiny nit

exercises/practice/isbn-verifier/tests.ua Outdated Show resolved Hide resolved
@vaeng vaeng merged commit 68a35f6 into main Nov 26, 2024
2 checks passed
@vaeng vaeng deleted the add-isbn-verifier branch November 26, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants