Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exercises(binary-search): example: improve #254

Merged
merged 2 commits into from
Mar 15, 2023
Merged

exercises(binary-search): example: improve #254

merged 2 commits into from
Mar 15, 2023

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Mar 12, 2023

Changes:

  • Make buffer no longer an optional. This means we now never return SearchError.NullBuffer, but tere was no test case for it.
  • Make the implementation more standard, avoiding possible overflow when calculating mid.

I will later PR to make this exercise return ?usize instead.

Refs: #229

@ee7 ee7 requested a review from ErikSchierboom March 12, 2023 13:24
This was referenced Mar 12, 2023
Merged
Merged
@ee7 ee7 merged commit 6a2287d into exercism:main Mar 15, 2023
@ee7 ee7 deleted the exercises-binary-search-example branch March 15, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ee7 @ErikSchierboom