v3: acl bug fix removing the "omitempty" tag from the acl DBAASOpensearchAclConfigAcl list #677
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the
omitempty
tag from theacl DBAASOpensearchAclConfigAcls
list, because it will remove theacl: []
from thepayload
if the list is empty therefore it will trigger api error if someone tried to delete the last acl user from the list.with the
omitempty
the payload with an empty list will look like this:which will trigger an error
Bad Request: Invalid value in [3].acls - should be a Collection
Without the
omitempty
the payload with an empty list will look like this:Which will not trigger any error.
Checklist
(For exoscale contributors)