Skip to content

Commit

Permalink
[eas-build-job] Add appId and initiatingUserId to all job schemas (
Browse files Browse the repository at this point in the history
…#450)

We want the new orchestrator to not need to know about initiating user ID or app ID.

https://github.com/expo/workflow-orchestration/blob/a035d7ea5fa0af1bbdaeca86e862ef99e6a54c4d/internal/watcher/watcher.go#L395-L400

After this is merged, going to upgrade and add them in `www` and `turtle-v2`.

Once this is done, going to make them required and remove the properties from `turtle-v2`.
  • Loading branch information
sjchmiela authored Oct 18, 2024
1 parent cec92f6 commit b495105
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/eas-build-job/src/android.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ export interface Job {
loggerLevel?: LoggerLevel;

workflowInterpolationContext?: never;

initiatingUserId?: string;
appId?: string;
}

const SecretsSchema = Joi.object({
Expand Down Expand Up @@ -177,4 +180,7 @@ export const JobSchema = Joi.object({
submitProfile: Joi.string(),
}),
loggerLevel: Joi.string().valid(...Object.values(LoggerLevel)),

initiatingUserId: Joi.string(),
appId: Joi.string(),
});
3 changes: 3 additions & 0 deletions packages/eas-build-job/src/generic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ export namespace Generic {
triggeredBy: z.literal(BuildTrigger.GIT_BASED_INTEGRATION),
loggerLevel: z.nativeEnum(LoggerLevel).optional(),
workflowInterpolationContext: StaticWorkflowInterpolationContextZ.optional(),

initiatingUserId: z.string().optional(),
appId: z.string().optional(),
});

const PathJobZ = CommonJobZ.extend({
Expand Down
6 changes: 6 additions & 0 deletions packages/eas-build-job/src/ios.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ export interface Job {
loggerLevel?: LoggerLevel;

workflowInterpolationContext?: never;

initiatingUserId?: string;
appId?: string;
}

const SecretsSchema = Joi.object({
Expand Down Expand Up @@ -211,4 +214,7 @@ export const JobSchema = Joi.object({
submitProfile: Joi.string(),
}),
loggerLevel: Joi.string().valid(...Object.values(LoggerLevel)),

initiatingUserId: Joi.string(),
appId: Joi.string(),
});

0 comments on commit b495105

Please sign in to comment.