[ENG-10412] Add metadataLocation to ArchiveSource type
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szdziedzic
reviewed
Dec 14, 2023
khamilowicz
force-pushed
the
piotrekszeremeta/eng-10412-ui-to-inspect-the-contents-of-eas-build-archive-for-a-build
branch
2 times, most recently
from
3410f01 to
4af1d55
Compare
szdziedzic
reviewed
Dec 14, 2023
There was a problem hiding this comment.
You can also add some tests for a new metadataLocation
This is probably nitpicking, but what do you think about changing metadataLocation to metadataFileLocation or some other more specific name? I'm proposing this because we already have a metadata concept which means something different.
packages/build-tools/src/steps/utils/ios/credentials/__tests__/manager.test.ios.ts
Outdated
Show resolved
Hide resolved
packages/build-tools/src/ios/credentials/__tests__/manager.test.ios.ts
Outdated
Show resolved
Hide resolved
khamilowicz
force-pushed
the
piotrekszeremeta/eng-10412-ui-to-inspect-the-contents-of-eas-build-archive-for-a-build
branch
from
4af1d55 to
bf54395
Compare
szdziedzic
approved these changes
Dec 18, 2023
khamilowicz
force-pushed
the
piotrekszeremeta/eng-10412-ui-to-inspect-the-contents-of-eas-build-archive-for-a-build
branch
from
bf54395 to
23e85a6
Compare
It is used to store location of the project archive metadata file
khamilowicz
force-pushed
the
piotrekszeremeta/eng-10412-ui-to-inspect-the-contents-of-eas-build-archive-for-a-build
branch
from
23e85a6 to
fc2a8c4
Compare
khamilowicz
deleted the
piotrekszeremeta/eng-10412-ui-to-inspect-the-contents-of-eas-build-archive-for-a-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is used to store location of the project archive metadata file
Why
ENG-10412