[steps] [ENG-14503] Don't wrap b64-encoded values on Linux #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using set-env command base64-encode the value of the env var before saving to a file See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
When collecting envs base64-decode them See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
Removed the env utils which are no longer used See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
Added explicit encoding when decoding from b64 See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
…-14503_base64_encode_envs_in_custom_builds
Linux systems add line wraps to b64 encoded values after 76 characters by default. We don't want that See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
Linux systems add line wraps to b64 encoded values after 76 characters by default. We don't want that See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
radoslawkrzemien
requested review from
szdziedzic and
sjchmiela
as code owners
sjchmiela
requested changes
Jan 13, 2025
Comment on lines
+23
to
+27
| if [[ "$OSTYPE" == "linux"* ]]; then | ||
| echo -n "$VALUE" | base64 -w 0 > $__EXPO_STEPS_ENVS_DIR/$NAME | ||
| else | ||
| echo -n "$VALUE" | base64 > $__EXPO_STEPS_ENVS_DIR/$NAME | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if [[ "$OSTYPE" == "linux"* ]]; then | |
| echo -n "$VALUE" | base64 -w 0 > $__EXPO_STEPS_ENVS_DIR/$NAME | |
| else | |
| echo -n "$VALUE" | base64 > $__EXPO_STEPS_ENVS_DIR/$NAME | |
| fi | |
| echo -n "$VALUE" | base64 -w 0 > $__EXPO_STEPS_ENVS_DIR/$NAME |
-w [number] works in macOS (even though --help doesn't mention it). Can you confirm it works in Linux too?
There was a problem hiding this comment.
I can confirm it doesn't work on macOS, got an error trying to run it on my machine
There was a problem hiding this comment.
radoslawkrzemien@MacBook-Pro-9 ~ % echo czescstaszekawsumiedobrze | base64 -w 0
base64: invalid option -- w
Usage: base64 [-Ddh] [-b num] [-i in_file] [-o out_file]
-b, --break break encoded string into num character lines
-Dd, --decode decodes input
-h, --help display this message
-i, --input input file (default: "-" for stdin)
-o, --output output file (default: "-" for stdout)
There was a problem hiding this comment.
Fascinating! On my computer it doesn't do that!
> echo czescradekcotamuciebie | base64 -w 0
Y3plc2NyYWRla2NvdGFtdWNpZWJpZQo=
> echo czescradekcotamuciebie | base64 -w 6
Y3plc2
NyYWRl
a2NvdG
FtdWNp
ZWJpZQ
o=
I guess then it's ok to do it like you're doing it. Thanks for confirming!
There was a problem hiding this comment.
I wonder what is the cause of that. Guess it's better to be safe than sorry at least for now
sjchmiela
approved these changes
Jan 14, 2025
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-14503_base64_encode_envs_in_custom_builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Linux systems add line wraps to b64 encoded values after 76 characters by default. We don't want that
How
If
set-envis executed on a Linux systembase64command is called with-w 0option. It's not present in other systems therefore in other casebase64is called with no optionsTest Plan
Automated tests pass
Tested manually both for
iosandandroid