[eas-build-job] Allow steps in build jobs
#493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjchmiela
force-pushed
the
stanley/eng-14684-add-steps-to-build-job
branch
from
920c968 to
e2ffd37
Compare
sjchmiela
force-pushed
the
stanley/eng-14684-add-steps-to-build-job
branch
from
75a90c3 to
65f2537
Compare
sjchmiela
force-pushed
the
stanley/eng-14684-add-steps-to-build-job
branch
from
356398d to
465658d
Compare
szdziedzic
approved these changes
Jan 17, 2025
| export type PartialJob = z.infer<typeof PartialJobZ>; | ||
| export const PartialJobZ = z.union([PathJobZ.partial(), StepsJobZ.partial()]); | ||
| export const PartialJobZ = JobZ.partial(); |
There was a problem hiding this comment.
I don't know why but I believe doing so broke some types in Turtle and that's why I did this weird union with partials inside as a workaround 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
For workflows it'll be much easier to let users define
stepsin the workflow file instead of having to do the custom build config and stuff.How
Added ability to pass
stepsin build jobs. Alongside, we need to sendworkflowInteprolationContext, so added that too.Test Plan
Tested manually by running both manual and GitHub workflow build jobs. Also ran a custom build and a regular build from
eas-cli.