Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Pass build mode only in job #2138

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Nov 29, 2023

Why

We use two build modes meaning the same thing. In https://github.com/expo/universe/pull/14035 I'm merging them into the single job.mode.

How

Updated eas-build-job which already removed buildMode from metadata. Then adjusted code so it:

  • does not send buildMode in metadata
  • transforms internal buildMode to the GraphQL BuildMode.

Test Plan

In a test project, triggered:

they both ran as expected.

Copy link

linear bot commented Nov 29, 2023

ENG-10706 Resolve mode/buildMode situation

At the moment we:

  • store buildMode in www in TurtleBuild metadata
  • pass job.mode from www to turtle-api
  • the job.mode is what governs how the job is executed
  • ~metadata.buildMode~~ governs how the job is reported in metrics~ (commit)
  • metadata.buildMode governs how the job is charged for

We should have a single job.mode to govern it all.

Copy link

github-actions bot commented Nov 29, 2023

Size Change: +977 B (0%)

Total Size: 55.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55.5 MB +977 B (0%)

compressed-size-action

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b44ba6b) 54.18% compared to head (6884b7a) 54.20%.

Files Patch % Lines
packages/eas-cli/src/build/graphql.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
+ Coverage   54.18%   54.20%   +0.03%     
==========================================
  Files         509      509              
  Lines       18662    18657       -5     
  Branches     3742     3927     +185     
==========================================
+ Hits        10110    10112       +2     
+ Misses       8531     7856     -675     
- Partials       21      689     +668     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela force-pushed the stanley/eng-10706-resolve-modebuildmode-situation branch from aae9bab to fbd6b8c Compare December 6, 2023 14:23
@sjchmiela
Copy link
Contributor Author

/changelog-entry chore Upgrade eas-build-job and unify how we're handling buildMode.

Copy link

github-actions bot commented Dec 6, 2023

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela marked this pull request as ready for review December 6, 2023 15:37
@sjchmiela sjchmiela merged commit f0012f5 into main Dec 12, 2023
9 checks passed
@sjchmiela sjchmiela deleted the stanley/eng-10706-resolve-modebuildmode-situation branch December 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants