-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Pass build mode only in job
#2138
[eas-cli] Pass build mode only in job
#2138
Conversation
ENG-10706 Resolve mode/buildMode situation
At the moment we:
We should have a single |
Size Change: +977 B (0%) Total Size: 55.5 MB
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2138 +/- ##
==========================================
+ Coverage 54.18% 54.20% +0.03%
==========================================
Files 509 509
Lines 18662 18657 -5
Branches 3742 3927 +185
==========================================
+ Hits 10110 10112 +2
+ Misses 8531 7856 -675
- Partials 21 689 +668 ☔ View full report in Codecov by Sentry. |
aae9bab
to
fbd6b8c
Compare
/changelog-entry chore Upgrade |
✅ Thank you for adding the changelog entry! |
Why
We use two build modes meaning the same thing. In https://github.com/expo/universe/pull/14035 I'm merging them into the single
job.mode
.How
Updated
eas-build-job
which already removedbuildMode
from metadata. Then adjusted code so it:buildMode
in metadatabuildMode
to the GraphQLBuildMode
.Test Plan
In a test project, triggered:
EXPO_STAGING=1 easd build -p ios -e demo
EXPO_STAGING=1 easd build -p ios -e simulator
they both ran as expected.