Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] [ENG-9957] Reapply changes after fixing query in www #2209

Conversation

radoslawkrzemien
Copy link
Contributor

@radoslawkrzemien radoslawkrzemien commented Feb 1, 2024

Why

Follow up to #2073 and #2207
Companion of https://github.com/expo/universe/pull/14426 and https://github.com/expo/universe/pull/14427
Changes in cli were not related to the problems with cloud sql cpu usage, so can be safely reapplied once changes in www are deployed again

How

No additional changes made

Test Plan

Not needed

Deployment plan

  • www
  • website
  • cli

Copy link

linear bot commented Feb 1, 2024

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9ee9ea3) 54.16% compared to head (8774e6a) 54.16%.

Files Patch % Lines
packages/eas-cli/src/commands/build/list.ts 16.67% 4 Missing and 1 partial ⚠️
packages/eas-cli/src/build/metadata.ts 33.34% 2 Missing ⚠️
packages/eas-cli/src/commands/build/run.ts 50.00% 1 Missing ⚠️
packages/eas-cli/src/run/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2209      +/-   ##
==========================================
+ Coverage   54.16%   54.16%   +0.01%     
==========================================
  Files         516      516              
  Lines       18805    18814       +9     
  Branches     3968     3969       +1     
==========================================
+ Hits        10183    10188       +5     
- Misses       7931     7934       +3     
- Partials      691      692       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 1, 2024

Size Change: +4.82 kB (0%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB +4.82 kB (0%)

compressed-size-action

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

Copy link

github-actions bot commented Feb 5, 2024

✅ Thank you for adding the changelog entry!

@radoslawkrzemien radoslawkrzemien merged commit 69b0eda into main Feb 5, 2024
9 checks passed
@radoslawkrzemien radoslawkrzemien deleted the @radoslawkrzemien/ENG-9957-cli-reapply-changes-after-fixing-query branch February 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants